Skip to content

replace RGBFormat with explicit undefined #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

replace RGBFormat with explicit undefined #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/render/buffer/memo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ export class Memo extends RenderToTexture {
const height = options.height || 1;
const depth = options.depth || 1;

// RGBFormat was removed in r137 of ThreeJS
//options.format = [null, THREE.LuminanceFormat, THREE.LuminanceAlphaFormat, THREE.RGBFormat, THREE.RGBAFormat][@channels]
options.format = RGBAFormat;
options.width = _width = items * width;
Expand Down
2 changes: 1 addition & 1 deletion src/render/buffer/texture/datatexture.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export class DataTexture {
null,
CONST.LuminanceFormat,
CONST.LuminanceAlphaFormat,
CONST.RGBFormat,
undefined, // CONST.RGBFormat was removed in r137 of ThreeJS
CONST.RGBAFormat,
][this.channels];

Expand Down