Skip to content

Conversation

@macchiati
Copy link
Member

@macchiati macchiati commented Jul 19, 2025

Add consistency for noCurrency in first pass, more to come.

Note: while doing this, I noticed that consolecheck fails with some parameters. When the change was made to be multithreaded, the static Matchers (not thread-safe) needed to be changed to be Patterns .

This adds 3 new Subtypes (error codes), and cleans up a bit of the code.

CLDR-18840

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

Add consistency for noCurrency
@macchiati macchiati marked this pull request as ready for review July 20, 2025 22:43
@macchiati
Copy link
Member Author

@macchiati
Copy link
Member Author

@macchiati macchiati marked this pull request as draft July 30, 2025 15:10
@macchiati
Copy link
Member Author

This is just the tool part, but I'd like to get it merged.
TODO is in a later PR to hook it up to CLDRModify, transform the files, and merge
In a later ticket, post 48, adjust coverage, to hide these so that vetters don't have to touch them.

Copy link
Member

@btangmu btangmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm

@macchiati macchiati marked this pull request as ready for review July 31, 2025 15:25
@macchiati macchiati merged commit 5bedae0 into main Jul 31, 2025
20 checks passed
@macchiati macchiati deleted the CLDR-18840-resolution-fixes-for-consistency branch July 31, 2025 15:26
@macchiati macchiati restored the CLDR-18840-resolution-fixes-for-consistency branch August 6, 2025 15:58
AEApple pushed a commit to AEApple/cldr that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants