Skip to content

ICU-23270 ICU4J Maven improvements #3788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mihnita wants to merge 6 commits into
base: mihai_mvn_refactor
Choose a base branch
from
Open

ICU-23270 ICU4J Maven improvements #3788

mihnita wants to merge 6 commits into from
+887 −890

Conversation

@mihnita
Copy link
Contributor

@mihnita mihnita commented Dec 3, 2025 •
edited
Loading

Checklist

  • Required: Issue filed: ICU-23270
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable
  • Approver: Feel free to merge on my behalf

ALLOW_MANY_COMMITS=true

@mihnita mihnita requested a review from echeran December 3, 2025 23:23
@mihnita
Copy link
Contributor Author

mihnita commented Dec 3, 2025

Not yet ready, I will add fixes and will do heavy testing.
But if you want a head-start, I don't plan to touch the existing commits anymore.
Only add on top of them, and (likely) squash all the "churn" added in to a final "Cleanup" commit

@mihnita
Copy link
Contributor Author

mihnita commented Dec 3, 2025

Still to do: CI, update doc, testing (lots of it!)

@markusicu markusicu marked this pull request as draft December 4, 2025 17:37
@mihnita
ICU-23270 Various fixes for issues discovered during testing
197201b 
* Add missing licenses
* Fix xalan ver
* Fixes module name
* Report tooling versions in CI
* Use java 21 for format check
* Copyright s/2023/2025/
* Fix title for the generated site
* Add back taglet dependency to fix javadoc generation
* Revert version change for cldr-to-icu
* Exclude taglets code from the final artifact
* Remove incorrect Eclipse project files
* Fix artifact version in the release script
@mihnita mihnita force-pushed the mihai_mvn_refactor branch from adfab28 to 197201b Compare December 9, 2025 18:08
@jira-pull-request-webhook
Copy link

jira-pull-request-webhook bot commented Dec 9, 2025

Notice: the branch changed across the force-push!

  • icu4j/releases_tools/shared.sh is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@mihnita mihnita marked this pull request as ready for review December 9, 2025 19:16
@mihnita
Copy link
Contributor Author

mihnita commented Dec 9, 2025

Ready for review

@mihnita mihnita requested a review from yumaoka December 9, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@echeran echeran Awaiting requested review from echeran

@yumaoka yumaoka Awaiting requested review from yumaoka

Assignees

@echeran echeran

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mihnita @echeran