Update MSRV to 1.83 #7066
Update MSRV to 1.83 #7066
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
| @@ -46,7 +46,7 @@ where | |||
| } | |||
| } | |||
|
|
|||
| // TODO(MSRV 1.83): Make this more infallible by calculating the required length, | |||
| // TODO(sffc): Make this more infallible by calculating the required length, | |||
There was a problem hiding this comment.
@sffc I don't know what this means
|
This is in policy for ICU4X component crates. But, after releasing new versions of everything in 2.0, I think we should by default keep utility crates on the lower MSRV until the individual utils crates need the bump. |
|
Proposal:
|
|
WG Discussion on the above policy (#7066 (comment)):
Conclusion: yep, + policy edit LGTM: @Manishearth @sffc @zbraniecki |
fixes #7114 Based on WG conclusion in #7066 (comment)
3 participants
In policy and needed for #7065