Add debug unreachable check where we say it's unreachable #7087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
approved these changes
Oct 14, 2025
Member
robertbastian
left a comment
robertbastian
left a comment
There was a problem hiding this comment.
I don't know what the point of this is, I'd rather have a bug than a panic. It's enough to claim that this is unreachable, we don't have to generate the panic code.
Member
Author
|
I also feel this isn't something we need to do, but a debug assertion here is fine imo. |
Member
|
We don't generate panic code in release mode, only in debug mode. We apply this pattern in dozens of other places and it is consistent with our style guide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7062 (comment)