Add operator<=> and remove operator< operator and compareTo function (issue 155) #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grhoten any opinion about this? |
|
@nciric @markusicu and I discussed this in our weekly meeting and we dig into one of our portability document and find we may have problem to land this change due to the C++20 requirement. I would like to abandon this efforts but take some issue I learn from this PR to a different PR to address some issues I discovered and fix in this PR. |
This was referenced Jul 15, 2025
|
Park this PR until we all feel comfortable to require C++20 |
|
have some 2nd thought. reopen it. we should face to face discuss this first. |
grhoten
approved these changes
Jul 22, 2025
deonajulary06
pushed a commit
that referenced
this pull request
Aug 21, 2025
…(issue 155) (#160) * Remove operator< and compareTo and add operator<=> * Update ULocale.hpp * Fix hash test. Ensure the comparator sort correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #155
Also correct the comparsion of LocaleUtil and the test which depend on reverse behavior.