Skip to content

fix(app): typo #5112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −3
Open

fix(app): typo #5112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions app2/src/lib/transfer/shared/services/filling/create-context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,12 @@ export const createContext = Effect.fn((
args.fee.baseToken,
)

const shouldIncludeFees = shouldChargeFees(args.fee, uiStore.edition, args.sourceChain)
const shouldIncludeFees = shouldChargeFees(
args.fee,
uiStore.edition,
args.sourceChain,
args.destinationChain,
)

const produceBatch = Effect.gen(function*() {
if (shouldIncludeFees) {
Expand Down Expand Up @@ -173,7 +178,12 @@ export const createContext = Effect.fn((
)

const createIntents = (args: TransferArgs, baseAmount: TokenRawAmount): Intent[] => {
const shouldIncludeFees = shouldChargeFees(args.fee, uiStore.edition, args.sourceChain)
const shouldIncludeFees = shouldChargeFees(
args.fee,
uiStore.edition,
args.sourceChain,
args.destinationChain,
)
const baseIntent = createBaseIntent(args, baseAmount)

return Match.value(args.sourceChain.rpc_type).pipe(
Expand Down Expand Up @@ -241,7 +251,19 @@ const createBaseIntent = (
})

// Fee strategy: BTC edition only charges fees when going FROM Babylon
const shouldChargeFees = (fee: FeeIntent, edition: string, sourceChain: Chain): boolean => {
const shouldChargeFees = (
fee: FeeIntent,
edition: string,
sourceChain: Chain,
destinationChain?: Chain,
): boolean => {
const skip = ["union.union-1", "union.union-testnet-10"]
if (
skip.includes(sourceChain.universal_chain_id)
|| (destinationChain && skip.includes(destinationChain.universal_chain_id))
) {
return false
}
if (fee.baseAmount === 0n) {
return false
}
Expand Down