add onnxscript to optional dependencies for tests #2930
Merged
+16
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before merging this PR:
Summary
Update:
PyTorch 2.9 made changes to
torch.onnx.export():dynamodefault changed fromFalsetoTruewhich will use a modern set of translation logic.As long as RNN module is supported, we will continue usng `dynamo=False
Old state:
onnxscriptfor optional dependency testsop.Split(self, axis=dim, num_outputs=self.shape[dim])which returns a single SymbolicTensor that can't be iterated overop.SplitToSequence(self, axis=dim, keepdims=False)which returns a proper sequence, then used op.SequenceAt(sequence, i) to extract individual elements