Skip to content

Conversation

jafl
Copy link
Contributor

@jafl jafl commented Oct 11, 2025

…because < & > are comparison operators.

Fixes #4313

@jafl jafl requested a review from masatake October 11, 2025 22:45
@jafl jafl self-assigned this Oct 11, 2025
@jafl jafl requested a review from ksamborski October 11, 2025 22:46
Copy link

codecov bot commented Oct 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.91%. Comparing base (e6a4947) to head (dc0aa75).
⚠️ Report is 35 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4314      +/-   ##
==========================================
+ Coverage   85.88%   85.91%   +0.02%     
==========================================
  Files         248      248              
  Lines       63602    63717     +115     
==========================================
+ Hits        54624    54741     +117     
+ Misses       8978     8976       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masatake
Copy link
Member

@jafl, thank you.

Could you add Units/parser-typescript.r/github-issue-4313.d/args.ctags with the following contents:

--sort=no

?

The test input is small, but I like unsorted output when reading and understanding test cases.

@jafl jafl force-pushed the typescript-issue-4313 branch from 87aa0cb to dc0aa75 Compare October 14, 2025 15:19
@jafl
Copy link
Contributor Author

jafl commented Oct 14, 2025

@masatake Done.

@masatake masatake requested a review from Copilot October 15, 2025 17:48
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes a TypeScript parser issue where template parsing was incorrectly triggered by comparison operators (< and >) within function bodies, preventing proper function detection.

  • Removes parseTemplate from the function body parser sequence
  • Adds test case demonstrating the fix for comparison operators in function bodies

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
parsers/typescript.c Removes parseTemplate from parseFunctionBody parser sequence
Units/parser-typescript.r/github-issue-4313.d/input.ts Test input with comparison operators that previously broke parsing
Units/parser-typescript.r/github-issue-4313.d/expected.tags Expected parser output showing both functions are correctly detected
Units/parser-typescript.r/github-issue-4313.d/args.ctags Test configuration file

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jafl jafl merged commit a55b4ce into universal-ctags:master Oct 15, 2025
82 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeScript parsing fails

3 participants