-
Notifications
You must be signed in to change notification settings - Fork 116
chore(Commerce): Update version and UnoFeatures #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DevTKSS
wants to merge
1
commit into
unoplatform:master
Choose a base branch
from
DevTKSS:update-commerce
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,63 +1,64 @@ | ||
| <Project Sdk="Uno.Sdk"> | ||
| <PropertyGroup> | ||
| <TargetFrameworks>net9.0-android;net9.0-ios;net9.0-maccatalyst;net9.0-windows10.0.26100;net9.0-browserwasm;net9.0-desktop</TargetFrameworks> | ||
|
|
||
| <OutputType>Exe</OutputType> | ||
| <UnoSingleProject>true</UnoSingleProject> | ||
|
|
||
| <!-- Display name --> | ||
| <ApplicationTitle>Commerce</ApplicationTitle> | ||
| <!-- App Identifier --> | ||
| <ApplicationId>com.companyname.Commerce</ApplicationId> | ||
| <!-- Versions --> | ||
| <ApplicationDisplayVersion>1.0</ApplicationDisplayVersion> | ||
| <ApplicationVersion>1</ApplicationVersion> | ||
| <!-- | ||
| If you encounter this error message: | ||
| error NETSDK1148: A referenced assembly was compiled using a newer version of Microsoft.Windows.SDK.NET.dll. | ||
| Please update to a newer .NET SDK in order to reference this assembly. | ||
| This means that the two packages below must be aligned with the "build" version number of | ||
| the "Microsoft.Windows.SDK.BuildTools" package above, and the "revision" version number | ||
| must be the highest found in https://www.nuget.org/packages/Microsoft.Windows.SDK.NET.Ref. | ||
| --> | ||
| <!--<WindowsSdkPackageVersion>10.0.22621.28</WindowsSdkPackageVersion>--> | ||
|
|
||
| <!-- | ||
| UnoFeatures let's you quickly add and manage implicit package references based on the features you want to use. | ||
| https://aka.platform.uno/singleproject-features | ||
| --> | ||
| <UnoFeatures> | ||
| Material; | ||
| Hosting; | ||
| Toolkit; | ||
| Logging; | ||
| MVUX; | ||
| Mvvm; | ||
| Configuration; | ||
| Http; | ||
| Skia; | ||
| Serialization; | ||
| Localization; | ||
| Navigation; | ||
| ExtensionsCore; | ||
| SkiaRenderer; | ||
| </UnoFeatures> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <None Remove="products.json" /> | ||
| <Content Include="products.json" /> | ||
| <None Remove="reviews.json" /> | ||
| <Content Include="reviews.json" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <EmbeddedResource Include="products.json"> | ||
| <CopyToOutputDirectory>Always</CopyToOutputDirectory> | ||
| </EmbeddedResource> | ||
| <EmbeddedResource Include="reviews.json"> | ||
| <CopyToOutputDirectory>Always</CopyToOutputDirectory> | ||
| </EmbeddedResource> | ||
| </ItemGroup> | ||
| </Project> | ||
| <Project Sdk="Uno.Sdk"> | ||
| <PropertyGroup> | ||
| <TargetFrameworks>net9.0-desktop;net9.0-android;net9.0-ios;net9.0-maccatalyst;net9.0-windows10.0.26100;net9.0-browserwasm</TargetFrameworks> | ||
|
|
||
| <OutputType>Exe</OutputType> | ||
| <UnoSingleProject>true</UnoSingleProject> | ||
|
|
||
| <!-- Display name --> | ||
| <ApplicationTitle>Commerce</ApplicationTitle> | ||
| <!-- App Identifier --> | ||
| <ApplicationId>com.companyname.Commerce</ApplicationId> | ||
| <!-- Versions --> | ||
| <ApplicationDisplayVersion>1.0</ApplicationDisplayVersion> | ||
| <ApplicationVersion>1</ApplicationVersion> | ||
| <!-- | ||
| If you encounter this error message: | ||
| error NETSDK1148: A referenced assembly was compiled using a newer version of Microsoft.Windows.SDK.NET.dll. | ||
| Please update to a newer .NET SDK in order to reference this assembly. | ||
| This means that the two packages below must be aligned with the "build" version number of | ||
| the "Microsoft.Windows.SDK.BuildTools" package above, and the "revision" version number | ||
| must be the highest found in https://www.nuget.org/packages/Microsoft.Windows.SDK.NET.Ref. | ||
| --> | ||
| <!--<WindowsSdkPackageVersion>10.0.22621.28</WindowsSdkPackageVersion>--> | ||
|
|
||
| <!-- | ||
| UnoFeatures let's you quickly add and manage implicit package references based on the features you want to use. | ||
| https://aka.platform.uno/singleproject-features | ||
| --> | ||
| <UnoFeatures> | ||
| Material; | ||
| Hosting; | ||
| Toolkit; | ||
| Logging; | ||
| MVUX; | ||
| Mvvm; | ||
| Configuration; | ||
| HttpRefit; | ||
| Http; | ||
| Skia; | ||
| Serialization; | ||
| Localization; | ||
| Navigation; | ||
| <!--ExtensionsCore;--> | ||
| SkiaRenderer; | ||
| </UnoFeatures> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <None Remove="products.json" /> | ||
| <Content Include="products.json" /> | ||
| <None Remove="reviews.json" /> | ||
| <Content Include="reviews.json" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <EmbeddedResource Include="products.json"> | ||
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| </EmbeddedResource> | ||
| <EmbeddedResource Include="reviews.json"> | ||
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| </EmbeddedResource> | ||
| </ItemGroup> | ||
| </Project> | ||
44 changes: 22 additions & 22 deletions
44
...operties/PublishProfiles/win-arm64.pubxml → ...operties/PublishProfiles/win-arm64.pubxml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,22 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- | ||
| https://go.microsoft.com/fwlink/?LinkID=208121. | ||
| --> | ||
| <Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <PropertyGroup> | ||
| <PublishProtocol>FileSystem</PublishProtocol> | ||
| <Platform>arm64</Platform> | ||
| <RuntimeIdentifier>win-arm64</RuntimeIdentifier> | ||
| <PublishDir>bin\$(Configuration)\$(TargetFramework)\$(RuntimeIdentifier)\publish\</PublishDir> | ||
| <SelfContained>true</SelfContained> | ||
| <PublishSingleFile>False</PublishSingleFile> | ||
| <PublishReadyToRun Condition="'$(Configuration)' == 'Debug'">False</PublishReadyToRun> | ||
| <PublishReadyToRun Condition="'$(Configuration)' != 'Debug'">True</PublishReadyToRun> | ||
| <!-- Note: Trimming disabled by default as there may still be an issues with PublishTrimmed support: https://github.com/microsoft/CsWinRT/issues/373 --> | ||
| <!-- | ||
| <PublishTrimmed Condition="'$(Configuration)' != 'Debug'">True</PublishTrimmed> | ||
| <TrimMode>partial</TrimMode> | ||
| <SuppressTrimAnalysisWarnings>true</SuppressTrimAnalysisWarnings> | ||
| --> | ||
| </PropertyGroup> | ||
| </Project> | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- | ||
| https://go.microsoft.com/fwlink/?LinkID=208121. | ||
| --> | ||
| <Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <PropertyGroup> | ||
| <PublishProtocol>FileSystem</PublishProtocol> | ||
| <Platform>arm64</Platform> | ||
| <RuntimeIdentifier>win-arm64</RuntimeIdentifier> | ||
| <PublishDir>bin\$(Configuration)\$(TargetFramework)\$(RuntimeIdentifier)\publish\</PublishDir> | ||
| <SelfContained>true</SelfContained> | ||
| <PublishSingleFile>False</PublishSingleFile> | ||
| <PublishReadyToRun Condition="'$(Configuration)' == 'Debug'">False</PublishReadyToRun> | ||
| <PublishReadyToRun Condition="'$(Configuration)' != 'Debug'">True</PublishReadyToRun> | ||
| <!-- Note: Trimming disabled by default as there may still be an issues with PublishTrimmed support: https://github.com/microsoft/CsWinRT/issues/373 --> | ||
| <!-- | ||
| <PublishTrimmed Condition="'$(Configuration)' != 'Debug'">True</PublishTrimmed> | ||
| <TrimMode>partial</TrimMode> | ||
| <SuppressTrimAnalysisWarnings>true</SuppressTrimAnalysisWarnings> | ||
| --> | ||
| </PropertyGroup> | ||
| </Project> |
44 changes: 22 additions & 22 deletions
44
...Properties/PublishProfiles/win-x64.pubxml → ...Properties/PublishProfiles/win-x64.pubxml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,22 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- | ||
| https://go.microsoft.com/fwlink/?LinkID=208121. | ||
| --> | ||
| <Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <PropertyGroup> | ||
| <PublishProtocol>FileSystem</PublishProtocol> | ||
| <Platform>x64</Platform> | ||
| <RuntimeIdentifier>win-x64</RuntimeIdentifier> | ||
| <PublishDir>bin\$(Configuration)\$(TargetFramework)\$(RuntimeIdentifier)\publish\</PublishDir> | ||
| <SelfContained>true</SelfContained> | ||
| <PublishSingleFile>False</PublishSingleFile> | ||
| <PublishReadyToRun Condition="'$(Configuration)' == 'Debug'">False</PublishReadyToRun> | ||
| <PublishReadyToRun Condition="'$(Configuration)' != 'Debug'">True</PublishReadyToRun> | ||
| <!-- Note: Trimming disabled by default as there may still be an issues with PublishTrimmed support: https://github.com/microsoft/CsWinRT/issues/373 --> | ||
| <!-- | ||
| <PublishTrimmed Condition="'$(Configuration)' != 'Debug'">True</PublishTrimmed> | ||
| <TrimMode>partial</TrimMode> | ||
| <SuppressTrimAnalysisWarnings>true</SuppressTrimAnalysisWarnings> | ||
| --> | ||
| </PropertyGroup> | ||
| </Project> | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- | ||
| https://go.microsoft.com/fwlink/?LinkID=208121. | ||
| --> | ||
| <Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <PropertyGroup> | ||
| <PublishProtocol>FileSystem</PublishProtocol> | ||
| <Platform>x64</Platform> | ||
| <RuntimeIdentifier>win-x64</RuntimeIdentifier> | ||
| <PublishDir>bin\$(Configuration)\$(TargetFramework)\$(RuntimeIdentifier)\publish\</PublishDir> | ||
| <SelfContained>true</SelfContained> | ||
| <PublishSingleFile>False</PublishSingleFile> | ||
| <PublishReadyToRun Condition="'$(Configuration)' == 'Debug'">False</PublishReadyToRun> | ||
| <PublishReadyToRun Condition="'$(Configuration)' != 'Debug'">True</PublishReadyToRun> | ||
| <!-- Note: Trimming disabled by default as there may still be an issues with PublishTrimmed support: https://github.com/microsoft/CsWinRT/issues/373 --> | ||
| <!-- | ||
| <PublishTrimmed Condition="'$(Configuration)' != 'Debug'">True</PublishTrimmed> | ||
| <TrimMode>partial</TrimMode> | ||
| <SuppressTrimAnalysisWarnings>true</SuppressTrimAnalysisWarnings> | ||
| --> | ||
| </PropertyGroup> | ||
| </Project> |
44 changes: 22 additions & 22 deletions
44
...Properties/PublishProfiles/win-x86.pubxml → ...Properties/PublishProfiles/win-x86.pubxml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,22 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- | ||
| https://go.microsoft.com/fwlink/?LinkID=208121. | ||
| --> | ||
| <Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <PropertyGroup> | ||
| <PublishProtocol>FileSystem</PublishProtocol> | ||
| <Platform>x86</Platform> | ||
| <RuntimeIdentifier>win-x86</RuntimeIdentifier> | ||
| <PublishDir>bin\$(Configuration)\$(TargetFramework)\$(RuntimeIdentifier)\publish\</PublishDir> | ||
| <SelfContained>true</SelfContained> | ||
| <PublishSingleFile>False</PublishSingleFile> | ||
| <PublishReadyToRun Condition="'$(Configuration)' == 'Debug'">False</PublishReadyToRun> | ||
| <PublishReadyToRun Condition="'$(Configuration)' != 'Debug'">True</PublishReadyToRun> | ||
| <!-- Note: Trimming disabled by default as there may still be an issues with PublishTrimmed support: https://github.com/microsoft/CsWinRT/issues/373 --> | ||
| <!-- | ||
| <PublishTrimmed Condition="'$(Configuration)' != 'Debug'">True</PublishTrimmed> | ||
| <TrimMode>partial</TrimMode> | ||
| <SuppressTrimAnalysisWarnings>true</SuppressTrimAnalysisWarnings> | ||
| --> | ||
| </PropertyGroup> | ||
| </Project> | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- | ||
| https://go.microsoft.com/fwlink/?LinkID=208121. | ||
| --> | ||
| <Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <PropertyGroup> | ||
| <PublishProtocol>FileSystem</PublishProtocol> | ||
| <Platform>x86</Platform> | ||
| <RuntimeIdentifier>win-x86</RuntimeIdentifier> | ||
| <PublishDir>bin\$(Configuration)\$(TargetFramework)\$(RuntimeIdentifier)\publish\</PublishDir> | ||
| <SelfContained>true</SelfContained> | ||
| <PublishSingleFile>False</PublishSingleFile> | ||
| <PublishReadyToRun Condition="'$(Configuration)' == 'Debug'">False</PublishReadyToRun> | ||
| <PublishReadyToRun Condition="'$(Configuration)' != 'Debug'">True</PublishReadyToRun> | ||
| <!-- Note: Trimming disabled by default as there may still be an issues with PublishTrimmed support: https://github.com/microsoft/CsWinRT/issues/373 --> | ||
| <!-- | ||
| <PublishTrimmed Condition="'$(Configuration)' != 'Debug'">True</PublishTrimmed> | ||
| <TrimMode>partial</TrimMode> | ||
| <SuppressTrimAnalysisWarnings>true</SuppressTrimAnalysisWarnings> | ||
| --> | ||
| </PropertyGroup> | ||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,8 @@ | ||
| { | ||
| // To update the version of Uno please update the version of the Uno.Sdk here. See https://aka.platform.uno/upgrade-uno-packages for more information. | ||
| "msbuild-sdks": { | ||
| "Uno.Sdk": "6.0.67" | ||
| }, | ||
| "sdk": { | ||
| "allowPrerelease": false | ||
| } | ||
| } | ||
| { | ||
| "msbuild-sdks": { | ||
| "Uno.Sdk": "6.1.23" | ||
| }, | ||
| "sdk": { | ||
| "allowPrerelease": false | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider removing the commented-out ExtensionsCore feature entirely rather than leaving it as a comment, as this reduces code clutter and confusion about whether it should be enabled.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Team should verify its not longer needed please