Skip to content

fix(tdesign): add QRCode component support #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2025
Merged

fix(tdesign): add QRCode component support #880

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e26e3a
fix: add QRCode component support to TDesign resolver
Mrbunker Aug 29, 2025
139e97a
fix: only resolve TQrcode to QRCode
Mrbunker Aug 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/core/resolvers/tdesign.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,13 @@ export function TDesignResolver(options: TDesignResolverOptions = {}): Component
}
}

if (name.startsWith('TQrcode') || name.startsWith('Qrcode')) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why need name.startsWith('Qrcode') here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the above code
(name.startsWith('TTypography') || name.startsWith('Typography'))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested it and found that startsWith('Qrcode') is redundant.
I will remove it

return {
name: 'QRCode',
from: `tdesign-${library}${importFrom}`,
}
}

if (name.match(/^T[A-Z]/) || pluginList.includes(name)) {
const importName = name.match(/^T[A-Z]/) ? name.slice(1) : name

Expand Down
Loading