Skip to content

Conversation

@mdesouky
Copy link
Contributor

@mdesouky mdesouky commented May 23, 2025

Changes:

  • Allow building docker images for graviton instances (linux/arm64)

@mdesouky mdesouky requested a review from uptickmetachu May 23, 2025 02:28
@uptickmetachu
Copy link
Collaborator

This will need a manual fix to the docker image.

@mdesouky
Copy link
Contributor Author

This will need a manual fix to the docker image.

yep, will leave that to Monday

@mdesouky
Copy link
Contributor Author

Fixed

Dockerfile Outdated
RUN apt-get update
RUN apt-get install wget ca-certificates bash git git-crypt -y --no-install-recommends \
&& wget -q https://storage.googleapis.com/kubernetes-release/release/${KUBE_LATEST_VERSION}/bin/linux/amd64/kubectl -O /usr/local/bin/kubectl \
ENV TARGETARCH=""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct?

#14 [linux/amd64 stage-0 2/10] RUN apt-get update && apt-get install wget ca-certificates bash git git-crypt -y --no-install-recommends && case "$(dpkg --print-architecture)" in amd64) export TARGETARCH="amd64" ;; arm64) export TARGETARCH="arm64" ;; ) echo "Unsupported architecture: $(dpkg --print-architecture)"; exit 1 ;; esac && wget -q https://storage.googleapis.com/kubernetes-release/release/v1.21.3/bin/linux//kubectl -O /usr/local/bin/kubectl && chmod +x /usr/local/bin/kubectl && wget -q https://get.helm.sh/helm-v3.6.2-linux-.tar.gz -O - | tar -xzO linux-/helm > /usr/local/bin/helm && chmod +x /usr/local/bin/helm && helm plugin install https://github.com/jkroepke/helm-secrets --version v4.2.2 && wget -q https://github.com/mozilla/sops/releases/download/v3.7.3/sops-v3.7.3.linux. -O /usr/local/bin/sops && chmod +x /usr/local/bin/sops && apt-get clean && apt-get -y autoremove && rm -rf /var/lib/apt/lists/ && rm -rf /var/cache/apt/
From the logs in the build.

You are clearing TargetAch whereas we just want to drop that line and let it naturally exist.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

There must be a better way to do it instead of the case statement.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uptickmetachu OK fixed I used the existing TARGETARCH arg

@mdesouky mdesouky requested a review from uptickmetachu May 27, 2025 00:26
@mdesouky mdesouky merged commit 037cbae into develop May 27, 2025
2 checks passed
@mdesouky mdesouky deleted the PLT-1078/use-graviton-instances branch May 27, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants