-
Notifications
You must be signed in to change notification settings - Fork 2
Build docker images for graviton instances #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This will need a manual fix to the docker image. |
yep, will leave that to Monday |
|
Fixed |
Dockerfile
Outdated
| RUN apt-get update | ||
| RUN apt-get install wget ca-certificates bash git git-crypt -y --no-install-recommends \ | ||
| && wget -q https://storage.googleapis.com/kubernetes-release/release/${KUBE_LATEST_VERSION}/bin/linux/amd64/kubectl -O /usr/local/bin/kubectl \ | ||
| ENV TARGETARCH="" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct?
#14 [linux/amd64 stage-0 2/10] RUN apt-get update && apt-get install wget ca-certificates bash git git-crypt -y --no-install-recommends && case "$(dpkg --print-architecture)" in amd64) export TARGETARCH="amd64" ;; arm64) export TARGETARCH="arm64" ;; ) echo "Unsupported architecture: $(dpkg --print-architecture)"; exit 1 ;; esac && wget -q https://storage.googleapis.com/kubernetes-release/release/v1.21.3/bin/linux//kubectl -O /usr/local/bin/kubectl && chmod +x /usr/local/bin/kubectl && wget -q https://get.helm.sh/helm-v3.6.2-linux-.tar.gz -O - | tar -xzO linux-/helm > /usr/local/bin/helm && chmod +x /usr/local/bin/helm && helm plugin install https://github.com/jkroepke/helm-secrets --version v4.2.2 && wget -q https://github.com/mozilla/sops/releases/download/v3.7.3/sops-v3.7.3.linux. -O /usr/local/bin/sops && chmod +x /usr/local/bin/sops && apt-get clean && apt-get -y autoremove && rm -rf /var/lib/apt/lists/ && rm -rf /var/cache/apt/
From the logs in the build.
You are clearing TargetAch whereas we just want to drop that line and let it naturally exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you just want to set ARG TARGETARCH (not env)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uptickmetachu OK fixed I used the existing TARGETARCH arg

Changes: