Skip to content

Conversation

@JoviDeCroock
Copy link
Contributor

@JoviDeCroock JoviDeCroock commented Nov 25, 2022

Supersedes #381

TODO:

  • Remove CSB CI
  • Remove renovate
  • Replace graphql-tag with gql from @urql/core
  • Update Babel to latest
  • upgrade to node v16
  • renew license like the main repo
  • fix cosmos build, seems related to having to upgrade codemirror
  • fix tests
  • update and double check visual regression snapshots

This removes CircleCI entirely due to #402, we will publish manually for the time being and move to github-actions in a follow-up

Follow ups:

  • check if the chrome-manifest can conform to v3
  • move to github-actions for publishing
  • update electron
  • upgrade to webpack v5

@JoviDeCroock JoviDeCroock force-pushed the cleanup branch 5 times, most recently from 90a87bc to 92cbc57 Compare November 25, 2022 11:14
@JoviDeCroock JoviDeCroock marked this pull request as ready for review November 28, 2022 15:25
@andyrichardson
Copy link
Collaborator

andyrichardson commented Nov 29, 2022

Thanks for doing this Jovi!

Hmm, updating the snapshots from my mac/windows pc makes them fail in CI....

What command are you running? If you run yarn visual-regression it should be deterministic (runs in a container).

Edit: Looks like you updated the puppeteer version here but didn't update the version of puppeteer that is being used locally here.

This will result in two different versions of chrome/puppeteer being used - hence the differences.

Side note - buildkite/puppeteer is no longer maintained

@JoviDeCroock JoviDeCroock requested a review from kitten February 14, 2023 10:33
@JoviDeCroock JoviDeCroock force-pushed the cleanup branch 2 times, most recently from a9a03b8 to de6c542 Compare February 14, 2023 15:03
@JoviDeCroock JoviDeCroock merged commit 02d4086 into master Feb 14, 2023
@JoviDeCroock JoviDeCroock deleted the cleanup branch February 14, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants