Skip to content

Conversation

@patdhlk
Copy link
Collaborator

@patdhlk patdhlk commented Dec 10, 2025

Fix leading and trailing space handling in oneline_parser and add corresponding test cases

closes #51

@patdhlk patdhlk requested a review from juiwenchen December 10, 2025 07:54
@patdhlk patdhlk changed the title 🐛 [#51] Fix space handling 🐛 Fix space handling (#51) Dec 10, 2025
@patdhlk patdhlk self-assigned this Dec 10, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.41%. Comparing base (cb37a48) to head (65b725b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   89.39%   89.41%   +0.02%     
==========================================
  Files          29       29              
  Lines        2414     2419       +5     
  Branches      290      290              
==========================================
+ Hits         2158     2163       +5     
  Misses        161      161              
  Partials       95       95              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

),
],
)
def test_oneline_parser_space_separator(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greate! Could you add the following test case? so that we know escaping separator works? (I tested it works)

        # Title contain spaces
        (
            f"@  Title\ escape\ space ID_456{UNIX_NEWLINE}",
            {
                "title": "Title escape space",
                "id": "ID_456",
                "type": "impl",
                "start_column": 1,
                "end_column": 30,
            },
        ),

@patdhlk patdhlk merged commit bf3bd2c into main Dec 11, 2025
9 checks passed
@patdhlk patdhlk deleted the pd-fix-51 branch December 11, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OnelineParserInvalidWarning when using spaces as separators in comments

4 participants