演習問題にSandpackによる実行環境を追加 #889
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying utcode-learn with
|
| Latest commit: |
27a8ecf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://28fc5bf2.utcode-learn.pages.dev |
| Branch Preview URL: | https://code-sandpack.utcode-learn.pages.dev |
chvmvd
reviewed
Nov 28, 2025
Contributor
chvmvd
left a comment
chvmvd
left a comment
There was a problem hiding this comment.
途中までですが
後は、Pull requestのタイトルと説明欄を書いていただけると、ありがたいです 🙇
Pull requestの大まかな内容と差分だけからではわからない意図などを書いていただけるとレビューがしやすくなり助かります 🥰
| title: HTML | ||
| --- | ||
|
|
||
| import { Sandpack } from "@codesandbox/sandpack-react"; |
Contributor
There was a problem hiding this comment.
Comment on lines
26
to
34
| <Sandpack | ||
| template="static" | ||
| files={{ | ||
| "/index.html": firstCssHtml, | ||
| }} | ||
| options={{ | ||
| activeFile: "/index.html", | ||
| }} | ||
| /> |
Contributor
There was a problem hiding this comment.
説明でコードと画像があり、ここでもコードとプレビューをつけると、重複してわかりにくいように思います。
Comment on lines
+155
to
+164
| <Sandpack | ||
| template="static" | ||
| files={{ | ||
| "/index.html": yellowHelloCssHtml, | ||
| "/style.css": yellowHelloCssCss, | ||
| }} | ||
| options={{ | ||
| activeFile: "/index.html", | ||
| }} | ||
| /> |
Comment on lines
220
to
228
| <Sandpack | ||
| template="static" | ||
| files={{ | ||
| "/index.html": fooHtml, | ||
| }} | ||
| options={{ | ||
| activeFile: "/index.html", | ||
| }} | ||
| /> |
Contributor
There was a problem hiding this comment.
もとからで申し訳ないですが、_samples/fooフォルダの中身が実際の教材とズレていそうですね。
Comment on lines
-95
to
-96
| <ViewSource url={import.meta.url} path="_samples/weird-comparison" /> | ||
|
|
Contributor
There was a problem hiding this comment.
この後の説明の答えを確認するためにCodeSandboxが置いてあったので、これを消すなら説明も変えた方が良さそうですね。
Contributor
Author
There was a problem hiding this comment.
ここはViewSourceがあった方が良さそうですね。
Comment on lines
73
to
82
| <Sandpack | ||
| template="static" | ||
| files={{ | ||
| "/index.html": answerWhileHtml, | ||
| "/script.js": answerWhileJs, | ||
| }} | ||
| options={{ | ||
| activeFile: "/script.js", | ||
| }} | ||
| /> |
Contributor
There was a problem hiding this comment.
こちら動いていなさそうです...
macOSでFirefoxとGoogle Chromeで確認したのですが、いずれも表示されていなさそうでした。
Contributor
Author
There was a problem hiding this comment.
うーむ
これはどうしよう。
SyntaxError: Identifier 'i' has already been declared
となっている。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更内容
@codesandbox/sandpack-reactを追加raw-loaderを使ってサンプルファイルを読み込むように変更削除したファイル
Sandpack導入に伴い、ViewSource用に存在していた一部のサンプルファイルを削除