Skip to content

[oneDPL][RNG] Add Philox engine to the oneAPI spec #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[oneDPL][RNG] Add Philox engine to the oneAPI spec #653

wants to merge 1 commit into from

Conversation

ElenaTyuleneva
Copy link

@ElenaTyuleneva ElenaTyuleneva commented Oct 6, 2025 •
edited
Loading

Documented the oneDPL Philox RNG.

@akukanov akukanov added the DPL label Oct 6, 2025
@akukanov akukanov changed the title [oneDPL][RNG] Philox engine was added to the oneAPI spec [oneDPL][RNG] Add Philox engine to the oneAPI spec Oct 6, 2025
paveldyakov
paveldyakov reviewed Oct 7, 2025
View reviewed changes
Copy link
Contributor

@paveldyakov paveldyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contirbution
Please find some comments
In addition, could you please fix the type description in

template
using minstd_rand0_vec = linear_congruential_engine<sycl::vec<::std::uint_fast32_t, N>, 16807, 0, 2147483647>;

@ElenaTyuleneva ElenaTyuleneva force-pushed the dev/et/philox_addition branch from a355013 to b5b7143 Compare October 7, 2025 11:16
@ElenaTyuleneva
Copy link
Author

Thanks @paveldyakov for the review! All the comments were addressed.

In addition, could you please fix the type description in

template
using minstd_rand0_vec = linear_congruential_engine<sycl::vec<::std::uint_fast32_t, N>, 16807, 0, 2147483647>;

Sure, also done!

paveldyakov
paveldyakov approved these changes Oct 7, 2025
View reviewed changes
Copy link
Contributor

@paveldyakov paveldyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments have been addressed
Thank you!

@ElenaTyuleneva
Copy link
Author

@akukanov , could you please also take a look?

@akukanov
Copy link
Contributor

akukanov commented Oct 7, 2025

@akukanov , could you please also take a look?

Sure, I will. The minimal review period is two weeks, so there is no rush (yet) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@paveldyakov paveldyakov paveldyakov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
DPL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ElenaTyuleneva @akukanov @paveldyakov