Specialize error page when missing tenant #587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@reynir FYI the pipeline fails with formatting errors. Run |
Collaborator
Author
|
Unfortunately it seems ocamlformat does not like mixing attributes and extension points. I'll see if I can massage the attribute so the autoformat is less jarring. |
By returning an empty 404 we don't leak information what the web service provides. Log a message to console what went wrong and what might need to be done.
For less jarring autoformat(!)
reynir
force-pushed
the
feature/missing-tenant
branch
from
5ad0acf to
51da20b
Compare
PossessedC0bra
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current behavior we redirect to
/not-foundon errors in the tenant middleware. One such error is when there is no such tenant. This means when you access the web service with a host name where no tenant is configured it will endlessly redirect to/not-found. This specializes the case when the error isSessionTenantNotFoundand renders a not found page. The error message could be improved.Update: after discussion with Yannick the error page is an empty 404 so that we don't reveal to probes what service we run. An error message aimed at operators is logged suggesting what might have gone wrong.
This addresses https://gitlab.uzh.ch/econ/study-coordination/pool/-/issues/312.