Skip to content

Conversation

@gperdomor
Copy link
Contributor

Description

This PR change prettier config and reformat the code using the new values... Merge this first #22

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@gperdomor gperdomor requested a review from v-checha as a code owner October 31, 2025 03:25
.get('/api/auth/me')
.set('Authorization', 'Bearer invalid-token')
.expect(401);
return request(app.getHttpServer()).get('/api/auth/me').set('Authorization', 'Bearer invalid-token').expect(401);

Check failure

Code scanning / CodeQL

Hard-coded credentials Critical test

The hard-coded value "Bearer invalid-token" is used as
authorization header
.
Copy link
Owner

@v-checha v-checha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clear why you removed prettier configuration.

"printWidth": 120,
"singleQuote": true,
"trailingComma": "all",
"printWidth": 100,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clear why you removed prettier configuration.

@gperdomor
Copy link
Contributor Author

Not clear why you removed prettier configuration.

Hey man, basically just because the values are the default values from prettier... the only change that is not a default value is the print width (default is 80)

@v-checha v-checha merged commit d5d7bd9 into v-checha:main Nov 3, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants