chore: prevent FOUC on dev pages using display: none #10319
+9
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
changed the title
|
web-padawan
reviewed
Oct 14, 2025
| '</title>', | ||
| ` | ||
| </title> | ||
| <link rel="preload" href="/packages/aura/src/fonts/InstrumentSans/InstrumentSans.woff2" as="font" type="font/woff2" crossorigin> |
There was a problem hiding this comment.
This would only work for yarn start:aura but not when running yarn start and opening aura.html
Also note that this would not apply to dev pages that are being deployed to GitHub Actions.
How about adding this to aura.html directly and checking if it's present here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the
opacitytransition with a straightforwarddisplay: noneto prevent flashes of unstyled web components on dev pages. It also preloads theInstrumentSansfont on Aura pages to avoid flashes of unstyled text. Using a CSS transition seems unnecessary and can be distracting when profiling performance.Type of change