Skip to content

Conversation

@DiegoCardoso
Copy link
Contributor

@DiegoCardoso DiegoCardoso commented Oct 30, 2025

Description

This should prevent a bug in Firefox where selecting slotted elements in components with a shadow root would cause the tab to become frozen.

The same fix should be done to other elements with the tooltip slot placed as a direct child of the shadow root.

Fixes #10396

Type of change

  • Bugfix

This should prevent a bug in Firefox where selecting slotted elements in
components with shadow root would cause the tab to become frozen.
@jouni
Copy link
Member

jouni commented Nov 3, 2025

@DiegoCardoso, could you test if this still works if you set display: contents on the container element? We’re planning on doing that for all field components in #10320, making the container elements irrelevant (so potential for removal at some point).

@DiegoCardoso
Copy link
Contributor Author

It looks like it still works after changing the container to display: contents.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2025

@web-padawan web-padawan removed the request for review from tomivirkki November 3, 2025 14:46
@web-padawan web-padawan merged commit da1bd50 into main Nov 3, 2025
9 checks passed
@web-padawan web-padawan deleted the fix/firefox-selection-crash branch November 3, 2025 14:47
@vaadin-bot
Copy link
Collaborator

Hi @DiegoCardoso and @web-padawan, when i performed cherry-pick to this commit to 24.9, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick da1bd50
error: could not apply da1bd50... fix: move tooltip slot to field container (#10410)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @DiegoCardoso and @web-padawan, when i performed cherry-pick to this commit to 24.8, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick da1bd50
error: could not apply da1bd50... fix: move tooltip slot to field container (#10410)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Highlighting text causes Firefox to freeze

6 participants