refactor: register CSS custom property to read its computed value directly #10531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
force-pushed
the
replace-form-layout-before-workaround
branch
from
156ca87 to
49c21f7
Compare
vursen
changed the title
vursen
changed the title
vursen
requested review from
DiegoCardoso and
tomivirkki
and removed request for
tomivirkki and
web-padawan
tomivirkki
approved these changes
Dec 16, 2025
|
web-padawan
approved these changes
Dec 16, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 16, 2025
web-padawan
pushed a commit
that referenced
this pull request
Dec 16, 2025
…ectly (#10531) (#10688) Co-authored-by: Sergey Vinogradov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR explicitly registers the
--_min-width-labels-asideCSS custom property as a<length>. This allows its computed value to be read directly viagetComputedStyle()without having to assign it to a CSS property likebackground-position.Type of change