Skip to content

validate accessories for a vehicle #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vacool6 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

validate accessories for a vehicle #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 21 additions & 18 deletions controllers/vehicle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ module.exports.addVehicle = wrapper(async (req, res) => {
const user = await User.findById(userId);
const newVehicle = new Vehicle(req.body);
const accessoriesList = [];

if (!accessories) return res.send(`Vehicle accessory list is missing`);

for (let i of accessories) {
const part = await Accessory.find({ name: i.name });
if (part.length !== 0) {
Expand All @@ -40,7 +43,7 @@ module.exports.addVehicle = wrapper(async (req, res) => {
user.vehicles.push(newVehicle);
await newVehicle.save();
await user.save();
res.send(`Vehicle added to ${user.username}`);
return res.send(`Vehicle added to ${user.username}`);
});

module.exports.updateVehicleById = wrapper(async (req, res) => {
Expand All @@ -50,25 +53,25 @@ module.exports.updateVehicleById = wrapper(async (req, res) => {
});

module.exports.deleteVehicleById = wrapper(async (req, res) => {
// 1
// const { userId, vehicleId } = req.params;
// await User.findByIdAndUpdate(userId, { $pull: { vehicles: vehicleId } });
// const accessories = await Accessory.find();
// 1
// const { userId, vehicleId } = req.params;
// await User.findByIdAndUpdate(userId, { $pull: { vehicles: vehicleId } });
// const accessories = await Accessory.find();

// for (let i of accessories) {
// const updatedAccessories = [];
// for (let j of i.usedIn) {
// if (ObjectID(j).valueOf() !== vehicleId) {
// updatedAccessories.push(j);
// }
// }
// i.usedIn = updatedAccessories;
// await i.save();
// }
// await Vehicle.findByIdAndDelete(vehicleId);
// res.send("Vehicle deleted!");
// for (let i of accessories) {
// const updatedAccessories = [];
// for (let j of i.usedIn) {
// if (ObjectID(j).valueOf() !== vehicleId) {
// updatedAccessories.push(j);
// }
// }
// i.usedIn = updatedAccessories;
// await i.save();
// }
// await Vehicle.findByIdAndDelete(vehicleId);
// res.send("Vehicle deleted!");

// 2
// 2
const { vehicleId } = req.params;
await User.findByIdAndUpdate(vehicle.owner, {
$pull: { vehicles: vehicleId },
Expand Down