[#583][Delta] Ensure resources are properly sent again if envoy unsubscribes then subscribes again to a resource #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e uniform between sotw and delta Signed-off-by: Valerian Roche <[email protected]>
Signed-off-by: Valerian Roche <[email protected]>
…nvoy unsubscribes then subscribes again to a resource Signed-off-by: Valerian Roche <[email protected]>
valerian-roche
force-pushed
the
vr/delta-subscribe
branch
from
cdd34ba to
ea51144
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the fix for envoyproxy#583 related to resources being unsubscribed from then subscribed to again
This one applies to both simple and linear cache when using the delta protocol.
Actionable cases would likely only impact delta-ADS as EDS outside of ADS does not share streams and will therefore usually not have multiple resources this way
The logger issue is related to sotw-ADS which is part of a followup PR
This PR is built on top of envoyproxy#584 as the sotw part will be heavily relying on it