Skip to content

Add min select size #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add min select size #101

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c25a81a
prepare script
ludwighen Mar 23, 2021
c69c1b9
Update package.json
ludwighen Mar 23, 2021
7cf9bb0
adding min select size
ludwighen Mar 23, 2021
0921b35
Update package.json
ludwighen Mar 23, 2021
75153d1
Update package.json
ludwighen Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions src/SelectableGroup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export type TSelectableGroupProps = {
* @type boolean
*/
fixedPosition?: boolean
minSelectSize?: number
}

export class SelectableGroup extends Component<TSelectableGroupProps> {
Expand All @@ -110,6 +111,7 @@ export class SelectableGroup extends Component<TSelectableGroupProps> {
allowMetaClick: false,
allowShiftClick: false,
selectOnClick: true,
minSelectSize: 0
}

state = { selectionMode: false }
Expand Down Expand Up @@ -347,7 +349,6 @@ export class SelectableGroup extends Component<TSelectableGroupProps> {
return
}
this.mouseMoveStarted = true
this.mouseMoved = true

const { mouseDownData } = this
const { clientX, clientY } = evt
Expand Down Expand Up @@ -376,8 +377,17 @@ export class SelectableGroup extends Component<TSelectableGroupProps> {
offsetHeight: selectboxState.height || 1,
}

this.selectItems(selectboxBounds)
this.props.duringSelection!([...this.selectingItems])
if (
!this.props.minSelectSize ||
this.props.minSelectSize < selectboxBounds.width ||
this.props.minSelectSize < selectboxBounds.height
)
{
this.mouseMoved = true
this.selectItems(selectboxBounds)
this.props.duringSelection!([...this.selectingItems])
}

this.mouseMoveStarted = false
}

Expand Down Expand Up @@ -612,15 +622,16 @@ export class SelectableGroup extends Component<TSelectableGroupProps> {
this.preventEvent(evt.target, 'click')
}

this.setSelectboxState!({
x: 0,
y: 0,
width: 0,
height: 0,
})
this.props.onSelectionFinish!([...this.selectedItems])
}

this.setSelectboxState!({
x: 0,
y: 0,
width: 0,
height: 0,
})

this.toggleSelectionMode()
this.cleanUp()
this.mouseMoved = false
Expand Down