Skip to content

Conversation

adam-fowler
Copy link
Collaborator

No description provided.

Signed-off-by: Adam Fowler <[email protected]>
@adam-fowler adam-fowler requested a review from fabianfett August 25, 2025 14:30
Copy link

✅ Pull request has performance improvements ✅

Summary
===============================================================================
Threshold deviations for ValkeyBenchmarks:Connection: Create and drop benchmark
===============================================================================
Malloc (total) (K, %) main pull_request Difference % Threshold %
p25 172 148 -13 5
p50 172 150 -12 5
p75 194 153 -21 5

New baseline 'pull_request' is BETTER than the 'main' baseline thresholds.

Full Benchmark Comparison

Comparing results between 'main' and 'pull_request'

Host 'ccc48c447dac' with 4 'x86_64' processors with 15 GB memory, running:
#18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025

ValkeyBenchmarks

Client: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 77 77 78 81 82 82 82 6
pull_request 77 77 78 80 81 81 81 6
Δ 0 0 0 -1 -1 -1 -1 0
Improvement % 0 0 0 1 1 1 1 0

Client: GET benchmark | parallel 20 | 20 concurrent connections metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 92 95 98 101 103 107 107 24
pull_request 90 97 98 100 102 111 111 25
Δ -2 2 0 -1 -1 4 4 1
Improvement % 2 -2 0 1 1 -4 -4 1

Connection: Create and drop benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 172 172 172 194 208 208 208 4
pull_request 141 148 150 153 185 185 185 5
Δ -31 -24 -22 -41 -23 -23 -23 1
Improvement % 18 14 13 21 11 11 11 1

Connection: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 4 4 4 4 4 4 4 8
pull_request 4 4 4 4 4 4 4 8
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

Connection: Pipeline benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 36 36 37 37 37 37 37 5
pull_request 37 37 37 37 37 37 37 4
Δ 1 1 0 0 0 0 0 -1
Improvement % -3 -3 0 0 0 0 0 -1

HashSlot – {user}.whatever metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 19
pull_request 0 0 0 0 0 0 0 19
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

ValkeyCommandEncoder – Command with 7 words metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 739
pull_request 0 0 0 0 0 0 0 754
Δ 0 0 0 0 0 0 0 15
Improvement % 0 0 0 0 0 0 0 15

ValkeyCommandEncoder – Simple GET metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 1913
pull_request 0 0 0 0 0 0 0 1920
Δ 0 0 0 0 0 0 0 7
Improvement % 0 0 0 0 0 0 0 7

ValkeyCommandEncoder – Simple MGET 15 keys metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 361
pull_request 0 0 0 0 0 0 0 362
Δ 0 0 0 0 0 0 0 1
Improvement % 0 0 0 0 0 0 0 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant