Reject bad ipv6 hostnames #2076
Conversation
erikdubbelboer
force-pushed
the
master
branch
from
18bceed to
0ad54a4
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation to reject malformed IPv6 hostnames that contain mixed bracket syntax. It prevents the parser from accepting hostnames that incorrectly combine regular hostnames or IPv4 addresses with IPv6 bracket notation.
- Added validation to detect and reject hostnames with misplaced '[' or ']' characters outside proper IPv6 format
- Restructured the host parsing logic to check for invalid bracket usage before port validation
- Added comprehensive tests to verify rejection of mixed bracket hostname patterns
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| uri.go | Enhanced parseHost function to validate and reject hostnames with improper bracket usage |
| uri_test.go | Added test cases to verify rejection of malformed IPv6 hostnames with mixed bracket syntax |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if !validOptionalPort(colonPort) { | ||
| return nil, fmt.Errorf("invalid port %q after host", colonPort) | ||
| } else { | ||
| if bytes.IndexByte(host, '[') != -1 || bytes.IndexByte(host, ']') != -1 { |
There was a problem hiding this comment.
The code performs two separate IndexByte operations on the same host slice. Consider combining these into a single loop or using bytes.ContainsAny(host, []byte("[]")) to check for both characters in one operation.
| if bytes.IndexByte(host, '[') != -1 || bytes.IndexByte(host, ']') != -1 { | |
| if bytes.ContainsAny(host, "[]") { |
Copilot uses AI. Check for mistakes.
No description provided.