Skip to content

Conversation

erikdubbelboer
Copy link
Collaborator

No description provided.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements validation to reject URI hosts that contain multiple port delimiters (multiple colons), which is invalid according to URI standards. The change ensures that hosts like "192.168.1.1:1111:2222" or "example.com:80:8080" are properly rejected during URI parsing.

  • Adds validation logic to detect multiple port delimiters in host parsing
  • Includes comprehensive test coverage for both invalid and valid cases

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
uri.go Adds validation check for multiple port delimiters in parseHost function
uri_test.go Adds test cases to verify rejection of invalid hosts with multiple ports

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@erikdubbelboer erikdubbelboer merged commit bed90bc into master Oct 5, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant