Added interface for Advanced Compression API #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
- Coverage 95.37% 92.60% -2.77%
==========================================
Files 5 5
Lines 562 622 +60
==========================================
+ Hits 536 576 +40
- Misses 16 30 +14
- Partials 10 16 +6
Continue to review full report at Codecov.
|
|
any news on merging this? |
|
@valyala Friendly ping 2.5 years later 😂 Any chance you can take a look at this PR? |
|
Hey, any chance this PR to be merged? Checksum support is highly desirable feature. |
GrigoryEvko
added a commit
to GrigoryEvko/gozstd
that referenced
this pull request
Aug 2, 2025
- Add cparams.go with all compression parameters and strategies - Add CCtx type for advanced compression context management - Add methods: NewCCtx(), Reset(), SetParameter(), SetPledgedSrcSize(), Compress() - Add compress2() and compress2Internal() using ZSTD_compress2 - Support checksum flag and other compression parameters - Add tests for parameter setting and checksum functionality - Use void* pointers to match our CGO improvements
GrigoryEvko
added a commit
to GrigoryEvko/gozstd
that referenced
this pull request
Aug 2, 2025
…ng codebase Integrated community contributions: - PR valyala#49: CGO wrapper improvements for 5-7% performance gain on large buffers - Use void* instead of uintptr_t to avoid memory allocations - Direct Go slice usage via reflect.SliceHeader - PR valyala#25: Advanced Compression API with checksum support - Added CCtx type for advanced compression contexts - Added SetParameter/GetParameter methods - Added Reset and Compress2 methods - Full support for all ZSTD compression parameters - PR valyala#63: Exposed CompressDictLevel as public API - Allows fine-grained control over dictionary compression levels - PR valyala#66: RISC-V 64-bit architecture support - Updated Zig builder to 0.13.0 - Added linux_riscv64 target - PR valyala#60: Memory-optimized dictionary functions - Added NewCDictByRef/NewDDictByRef to avoid data copying - Reduces memory usage for large dictionaries Infrastructure improvements: - Created modern Dockerfile with Alpine Linux and latest Zig - Fixed build process issues with clean target - Updated minimum Go version to 1.24 Code organization: - Moved Docker configs to build/docker/ - Moved scripts to scripts/ - Moved upstream zstd to contrib/ - Moved test data to test/ - Created comprehensive examples in examples/ - Kept all Go source files in root for package compatibility Testing enhancements: - Added Silesia Corpus compression tests with speed measurements - Created 33 aggressive fuzz tests targeting known vulnerabilities - Added comprehensive tests for Advanced API - Added benchmarks comparing raw zstd vs wrapper performance The wrapper now shows 6-10% performance improvements for compression while maintaining identical compression ratios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, like the issue that was raised last fall (#16), I need checksum support for frames. The Advanced Compression API adds this capability, so I've added an interface onto it.