fix: optimize using constexpr and templates #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
As far as I understand, this removes a branch from code path at the expense of compiling separate versions of the function for different conditions. The approach might be useful. However, I'd apply it only for hot-path and after doing some measurements that justify increase in complexity/compilation time. |
Author
|
@variar, should I run benchmark using |
Author
|
@variar, is this pull request still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@variar,
I'm not sure of course, but maybe you're interested in rewriting some parameters of functions to create guaranteed C++17 metafunctions that are more optimized due to constant conditions and variables.
I doubt that the functions I fixed have a big impact on performance, but this is a step towards using such a method for functions that are frequently called.
More info here: https://stackoverflow.com/a/57211067
My tests on godbolt here: https://godbolt.org/z/4qq9n38Tz