Skip to content

#162: add female/male sign emojis #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ccostin93 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#162: add female/male sign emojis #168

ccostin93 wants to merge 1 commit into from

Conversation

@ccostin93
Copy link

@ccostin93 ccostin93 commented Dec 1, 2020

fixes #162

@coveralls
Copy link

coveralls commented Dec 2, 2020

Coverage Status

Coverage increased (+0.3%) to 92.625% when pulling 0686e9c on ccostin93:#162-male-female-sign into 9a90624 on vdurmont:master.

wax911
wax911 reviewed Aug 11, 2022
View reviewed changes
Copy link

@wax911 wax911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good practice to extend unit tests to cover the failing test case along with this 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wax911 wax911 wax911 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

female sign and male sign are not recognized by EmojiManager.containsEmoji(String)

3 participants

@ccostin93 @coveralls @wax911