-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(config): Add support for v1.1 protocol of secrets exec backend #23655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): Add support for v1.1 protocol of secrets exec backend #23655
Conversation
- This is necessary as the secrets exec config now contains a member of type `Value`
7d180fb
to
43b11bb
Compare
- That way its implementation can change without modifying the executables call site in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
@pront looks like the unit tests failed on windows, possibly because theres no
|
385b587
to
523e0eb
Compare
Change in force-push
|
…23655) * feat(config): Add support for v1.1 of datadog secrets manager * Update docs generator to generate unconstrained types - This is necessary as the secrets exec config now contains a member of type `Value` * Introduce new unit tests for the exec backend * Add changelog file * Stray line to format * Rename mock exec script and make it executable - That way its implementation can change without modifying the executables call site in the code. * Update src/secrets/exec.rs * Install python 3.10 on windows CI runs --------- Co-authored-by: Pavlos Rontidis <[email protected]> Co-authored-by: Thomas <[email protected]>
I think the issue is that |
If it is needed for Windows and works on Linux, I'd suggest to make it unconditional for uniformity. |
I would revert this change: #23655 (comment) I don't see any real benefit to it. And explicitly calling it will probably fix the the Windows failure. |
- Shebang invocation at top of script not working on windows builds where python is installed and located at the path
This reverts commit c4f9570.
This reverts commit fb51201.
7c79e25
to
d110486
Compare
Summary
The exec backend within the secrets framework works to fetch secrets by
exec
ing a provided path to a binary and communicating with it over a simple (but established) protocol. This protocol is versioned and currently Vector only supports 1 version.This PR introduces support for v1.1. An example of a program that is compliant with these new changes is the datadog-secrets-backend specifically the changes in the
v1
branch which will eventually become part of the new standard.The main changes to Vector were to include the backend configuration with each request to this binary. This means opening up new configuration options to the secrets global option.
Vector configuration
How did you test this PR?
Using the config about and building the
datadog-secrets-backend
from source.Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changelog
label to this PR.References
Notes
@vectordotdev/vector
to reach out to us regarding this PR.pre-push
hook, please see this template.cargo fmt --all
cargo clippy --workspace --all-targets -- -D warnings
cargo nextest run --workspace
(alternatively, you can runcargo test --all
)git merge origin master
andgit push
.Cargo.lock
), pleaserun
cargo vdev build licenses
to regenerate the license inventory and commit the changes (if any). More details here.