Skip to content

Conversation

MariusBgm
Copy link
Collaborator

@MariusBgm MariusBgm commented Sep 15, 2025

The raw field in slogs allows us to add debugging information in JSON.
In this case, add the FR ControllerConfig as a JSON object.

SILKIT-1827

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds raw JSON logging support to structured logging by introducing a raw key that allows JSON objects to be embedded directly into log messages. The specific implementation adds FlexrayControllerConfig JSON serialization to message tracing.

  • Adds new raw key to structured logging keys
  • Implements JSON serialization for FlexrayControllerConfig in message tracing
  • Updates logging infrastructure to handle raw JSON values without double-escaping

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
SilKit/source/services/logging/StructuredLoggingKeys.hpp Adds new raw key and converts string keys to string_view for performance
SilKit/source/services/logging/SilKitFmtFormatters.hpp Removes trailing empty line
SilKit/source/services/logging/MessageTracing.hpp Adds YamlParser include and FlexrayControllerConfig JSON serialization to trace functions
SilKit/source/services/logging/Logger.cpp Updates JSON formatting to handle raw key values without escaping
SilKit/source/core/internal/ServiceDescriptor.hpp Updates return type to use string_view for key names
SilKit/source/config/YamlWriter.hpp Adds FlexrayControllerConfig Write method declaration
SilKit/source/config/YamlWriter.cpp Implements FlexrayControllerConfig Write method
SilKit/source/config/YamlParser.hpp Adds include guard for Windows GetCurrentTime macro

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant