-
Notifications
You must be signed in to change notification settings - Fork 29.3k
docs: remove removed examples guidelines reference from PR template #83043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remove removed examples guidelines reference from PR template #83043
Conversation
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
mmm interesting - wonder if the entire sub heading should disappear though? or we likely need to reformulate the section |
Since https://github.com/vercel/next.js/blob/canary/contributing.md also contains linting content, I think we can remove the |
Yeah - I mean, right now the whole thing wouldn't make any sense, the heading talks about examples, the content about linting. Let's drop it all this time around. The thing that I am a bit worried about is, addition of future examples, but I think we can proceed because:
|
Thanks for the reply, I'll edit it to remove the entire section :) docs: remove removed examples guidelines reference from PR template |
@icyJoseph Are examples added by the next.js team? |
I think the nextjs team is in charge of adding examples:) |
Depends. Some examples were added by 3rd parties, for various reasons, and they are still maintaining them as of today. |
Thanks for your reply! |
For Maintainers
What?
Removed the references to the now-deleted examples guidelines from the PR template. Specifically, removed the line about
since that file and folder were deleted in PR #77050.
Why?
The
/examples
folder and itsadding-examples.md
file were removed, so the reference in the PR template to those guidelines is outdated and misleading. Keeping those references causes confusion for contributors by pointing to non-existent documentation.How?
This ensures the PR template stays accurate, up-to-date, and helpful for contributors.