Skip to content

Conversation

wo-o29
Copy link
Contributor

@wo-o29 wo-o29 commented Aug 26, 2025

For Maintainers

What?

Removed the references to the now-deleted examples guidelines from the PR template. Specifically, removed the line about

The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md

since that file and folder were deleted in PR #77050.

Why?

The /examples folder and its adding-examples.md file were removed, so the reference in the PR template to those guidelines is outdated and misleading. Keeping those references causes confusion for contributors by pointing to non-existent documentation.

How?

  • Edited the PR template file.
  • Removed the outdated examples guidelines reference line.
  • Left other template content unchanged to preserve existing guidance.

This ensures the PR template stays accurate, up-to-date, and helpful for contributors.

@ijjk
Copy link
Member

ijjk commented Aug 26, 2025

Allow CI Workflow Run

  • approve CI run for commit: 9552b22

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Aug 26, 2025

Allow CI Workflow Run

  • approve CI run for commit: ca6768b

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@icyJoseph
Copy link
Contributor

mmm interesting - wonder if the entire sub heading should disappear though? or we likely need to reformulate the section

@wo-o29
Copy link
Contributor Author

wo-o29 commented Aug 27, 2025

mmm interesting - wonder if the entire sub heading should disappear though? or we likely need to reformulate the section

Since https://github.com/vercel/next.js/blob/canary/contributing.md also contains linting content, I think we can remove the Adding or Updating Examples section itself. What do you think?

@icyJoseph
Copy link
Contributor

mmm interesting - wonder if the entire sub heading should disappear though? or we likely need to reformulate the section

Since https://github.com/vercel/next.js/blob/canary/contributing.md also contains linting content, I think we can remove the Adding or Updating Examples section itself. What do you think?

Yeah - I mean, right now the whole thing wouldn't make any sense, the heading talks about examples, the content about linting. Let's drop it all this time around.

The thing that I am a bit worried about is, addition of future examples, but I think we can proceed because:

  • as you point out, that ship sailed when the actual section was removed 🤔
  • maintaining examples often falls on us, and today it is quite common for libraries/tooling to have a CLI, a 'How to do in Next.js', or LLMs just know how to generate a project from scratch

@wo-o29
Copy link
Contributor Author

wo-o29 commented Aug 27, 2025

mmm interesting - wonder if the entire sub heading should disappear though? or we likely need to reformulate the section

Since https://github.com/vercel/next.js/blob/canary/contributing.md also contains linting content, I think we can remove the Adding or Updating Examples section itself. What do you think?

Yeah - I mean, right now the whole thing wouldn't make any sense, the heading talks about examples, the content about linting. Let's drop it all this time around.

The thing that I am a bit worried about is, addition of future examples, but I think we can proceed because:

  • as you point out, that ship sailed when the actual section was removed 🤔
  • maintaining examples often falls on us, and today it is quite common for libraries/tooling to have a CLI, a 'How to do in Next.js', or LLMs just know how to generate a project from scratch

Thanks for the reply, I'll edit it to remove the entire section :)

docs: remove removed examples guidelines reference from PR template

@bndchris
Copy link

@icyJoseph Are examples added by the next.js team?

@wo-o29
Copy link
Contributor Author

wo-o29 commented Aug 31, 2025

@icyJoseph Are examples added by the next.js team?

I think the nextjs team is in charge of adding examples:)

@icyJoseph
Copy link
Contributor

@icyJoseph Are examples added by the next.js team?

Depends. Some examples were added by 3rd parties, for various reasons, and they are still maintaining them as of today.

@bndchris
Copy link

bndchris commented Sep 1, 2025

@icyJoseph Are examples added by the next.js team?

Depends. Some examples were added by 3rd parties, for various reasons, and they are still maintaining them as of today.

Thanks for your reply!

@icyJoseph icyJoseph merged commit 8f7790a into vercel:canary Sep 2, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants