-
Notifications
You must be signed in to change notification settings - Fork 122
[web] add PostgreSQL backend support #459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
@alex-holovach is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Add ability to configure PostgreSQL as a backend in the web UI settings. Users can now select PostgreSQL from the backend dropdown and provide a connection URL to view workflow data stored in a postgres database. Signed-off-by: Alex Holovach <[email protected]>
0f95d23 to
300a02c
Compare
Signed-off-by: Alex Holovach <[email protected]>
ebdd1cf to
5119a05
Compare
VaguelySerious
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Before we merge, can you add a changeset (pnpm changeset) with a patch change for web?
My other comment is relevant, but not in the way of merging this, and if you decide not to add that to this PR, I'll create a GH issue for it instead
| "@types/react-dom": "19", | ||
| "@workflow/core": "workspace:*", | ||
| "@workflow/world": "workspace:*", | ||
| "@workflow/world-postgres": "workspace:*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead, we should set the worlds as peer dependencies (or not put them in package.json at all), and when the web app first loads, validateWorldConfig or a similar server action should check the list of known package (or the package name manually provided) to see which of them are installed, and then disable + display tooltip warnings for those that aren't, mentioning e.g. npm install <package-name> to the user.
We expect users to not run into this, since presumably in order to use the o11y UI with their preferred world, they likely already use the world package locally, and must have had it installed, but if not, this prompts them to do so.
Added PostgreSQL as a backend option in the web UI settings, allowing users to view workflow data stored in a postgres database.