Couple fixes from SPEC CPU work #2751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide rr_graph_utils with full definition of lambda function. Remove/replace __attribute since MSVC doesn't know about it.
Contributor
There was a problem hiding this comment.
Hi @heshpdx , thank you for these changes.
Looking through the CI, this causes some of the regular tests to fail due to warnings. This is just from an unused variable which is easily resolved below.
Contributor
|
Google part of CI is down, so nightly test failures are expected. There is one unit test failing, but it's a known problem test that @soheilshahrouz is going to turn off for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple fixes from SPEC CPU work: