[Router] Fix intra-cluster pin handling for tiles with heterogeneous subtiles #3338
+58
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
Contributor
Author
|
Titan other results (with flat routing enabled - runtime difference is mainly due to machine load): |
Contributor
soheilshahrouz
left a comment
soheilshahrouz
left a comment
There was a problem hiding this comment.
Thansk Amin!
Is there a CI test for this?
Contributor
Author
|
@soheilshahrouz: Thanks! I’ve addressed your comments. We don’t have a test for this yet, but I’ve created an issue and will add one soon. |
soheilshahrouz
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the router when adding intra-cluster resources. Specifically, while retrieving the index of tile-level pins for blocks, there was an incorrect assumption that all sub-tile instances are of the same type. This PR fixes that bug and adds a clarifying comment to the function that returns this list.
To ensure the fix doesn’t introduce issues in existing architectures, I ran the titan_other benchmarks with the flat router enabled, and the results remained unchanged (as expected).