Skip to content

Fix #2773: send secure cookie when localhost #2775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
takeseem wants to merge 1 commit into from
+9 −1
Closed

Fix #2773: send secure cookie when localhost #2775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vertx-web-client/src/main/java/io/vertx/ext/web/client/impl/CookieStoreImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public Iterable<Cookie> get(Boolean ssl, String domain, String path) {
TreeMap<String, Cookie> matches = new TreeMap<>();

Consumer<Cookie> adder = c -> {
if (ssl != Boolean.TRUE && c.isSecure()) {
if (c.isSecure() && (!Boolean.TRUE.equals(ssl) && !"localhost".equals(domain))) {
return;
}
if (c.path() != null && !cleanPath.equals(c.path())) {
Expand Down
8 changes: 8 additions & 0 deletions vertx-web-client/src/test/java/io/vertx/ext/web/client/tests/SessionAwareWebClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,6 +542,14 @@ public void testCookieStore(TestContext context) {
validate(context, store.get(true, "test.vertx.io", "/"),
new String[] { "a", "b", "e" },
new String[] { "1", "2", "5" });

c = new DefaultCookie("localhost-secure", "http-localhost");
c.setDomain("localhost");
c.setPath("/");
store.put(c);

validate(context, store.get(true, "localhost", "/"), new String[] { "a", "localhost-secure" }, new String[] { "1", "http-localhost" });
validate(context, store.get(false, "localhost", "/"), new String[] { "a", "localhost-secure" }, new String[] { "1", "http-localhost" });
}

@Test
Expand Down
Loading