Fix view definition capture in DataHub for Vertica schemas with uppercase letters #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where view definitions were not captured in DataHub when Vertica schema names contained uppercase letters. The
table_schemacolumn inV_CATALOG.VIEWSdisplays schema names exactly as they were created. For example, if a schema was created asCREATE SCHEMA myschema1;, it would be displayed asmyschema1, whileCREATE SCHEMA mySchema2;would be displayed asmySchema2, preserving the original casing.The current code compares
table_schemausingtable_schema = lower(any_schema_in_the_database), which causes issues with schema names that have uppercase letters.This fix updates the query to use
lower(table_schema) = lower(any_schema_in_the_database), allowing DataHub to capture view definitions for schemas regardless of whether their names contain uppercase characters.