APP-9928 verify UpdateBinary behavior when checksum fails #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjirewis
reviewed
Oct 29, 2025
| test.That(t, err.Error(), test.ShouldContainSubstring, "sha256") | ||
|
|
||
| // Note: we leave the bad file there rather than deleting it when the checksum fails. | ||
| // The agent event loop should prevent it from being used because the cache isn't saved? |
There was a problem hiding this comment.
I'm unclear what this Note means, but I do think we should be cleaning up a downloaded file with a bad checksum right?
There was a problem hiding this comment.
yes -- would like to delete the bad file.
I'm guessing this is okay for now (it won't delete the failed-checksum download, but it also won't use it); can I ticket this change but not do it right away?
slightly worried this is load bearing in some way.
(before merging I'll recheck that I'm right about it not using the bad download)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safety follow-up to #158.
What changed
This doesn't change any prod behavior other than adding a warning log.
It adds 2 tests, ensuring that:
Why
Now that we have partial download support, it's plausible that we'll have corrupt downloads. The 'bad checksum' case is more important to test for.
Questions
UpdateBinarylogic will loop endlessly if the cloud has a bad checksum for a URL. I think we shouldn't protect against this case, but surfacing it in case others have thoughts.