Skip to content

Don't push empty rows #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't push empty rows #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions include/internal/basic_csv_parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,11 @@ namespace csv {
while (this->data_pos < in.size() && parse_flag(in[this->data_pos]) == ParseFlags::NEWLINE)
this->data_pos++;

// End of record -> Write record
this->push_field();
this->push_row();
// End of record -> Write non-empty record
if (this->field_length > 0 || !this->current_row.empty()) {
this->push_field();
this->push_row();
}

// Reset
this->current_row = CSVRow(data_ptr, this->data_pos, fields->size());
Expand Down
8 changes: 5 additions & 3 deletions single_include/csv.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7084,9 +7084,11 @@ namespace csv {
while (this->data_pos < in.size() && parse_flag(in[this->data_pos]) == ParseFlags::NEWLINE)
this->data_pos++;

// End of record -> Write record
this->push_field();
this->push_row();
// End of record -> Write non-empty record
if (this->field_length > 0 || !this->current_row.empty()) {
this->push_field();
this->push_row();
}

// Reset
this->current_row = CSVRow(data_ptr, this->data_pos, fields->size());
Expand Down
8 changes: 5 additions & 3 deletions single_include_test/csv.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7084,9 +7084,11 @@ namespace csv {
while (this->data_pos < in.size() && parse_flag(in[this->data_pos]) == ParseFlags::NEWLINE)
this->data_pos++;

// End of record -> Write record
this->push_field();
this->push_row();
// End of record -> Write non-empty record
if (this->field_length > 0 || !this->current_row.empty()) {
this->push_field();
this->push_row();
}

// Reset
this->current_row = CSVRow(data_ptr, this->data_pos, fields->size());
Expand Down