-
-
Notifications
You must be signed in to change notification settings - Fork 8
Refactor and v2 API #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4950b55 to
0e099e2
Compare
|
Marking as draft as this is incomplete for now. |
nrabulinski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's still WIP so just leaving comments about things that immediately caught my eye
|
@nrabulinski this should be ready to review. There's a problem in that mkRemovedOptionModule is implemented in terms of assertions, which is not part of evalModules but rather integrated into NixOS. Me we can just do a one-off thing for deprecating (For the record, my dotfiles are already using this branch) |
I work around this in wrapper-manager-hm-compat, by evaling assertions when creating the wrappers, you can see it here. Would be nice to have that upstream actually. |
Looking at the modules, what I don't know is how to load assertions.nix for each option that has a submodule, and collect all assertions for all submodules. |
|
In the end I did a one-off thing to deprecate .flags. We can look at implementing .assertions in a later PR. |
This is a major refactor for wrapper-managaer, basically rewriting it from sratch by learning from past mistakes.
There is a new function called
wrapWith, to create a single wrapper:If you are not using flakes, the calling API has changed, please apply these changes:
Old way of evaluating wrapper-manager without flakes:
New way of evaluating wrapper-manager without flakes: