For discussion: remove withParametersWebGL

[Pessimistress]

Needs

• Add blend parameter luma.gl#2061
• fix(webgl): Render pass parameter handling luma.gl#2062
• fix(webgl): enable polygon offset with depthBias luma.gl#2063

Change List

• Remove withParametersWebGL and setParametersWebGL from core
• Type props.parameters and Pass.getLayerParameters

[felixpalmer]

I wonder if we should have deprecated getPolygonOffset in v9. It is strange that it is called and accessor in the docs, but is in fact a roundabout way of setting GPU parameters.

Is there any reason to keep the function? I think it would be clearer to pass depthBias(SlopeScale) in props.parameters. In addition if depthBias is passed in props.parameters it will be overwritten even if getPolygonOffset isn't specified.

[ibgreen]

I certainly agree that it should not be called an "accessor" if that is really the case, as accessors operate on data rows and this function operates on a layer.

We can still deprecate a function at any time. But I believe the functionality of being able to adjust depth bias based on layer index is needed to address Z fighting so we can't just drop it, we need to have a replacement for this function.

[felixpalmer]

Just an idea: would it be useful if props.parameters could also accept a function to allow the application to control the final parameters? By passing in the Pass the Layer could have more control:

new Layer({
  ...,
  parameters: (pass: Pass, parameters: Parameters): Parameters {...}

})