qdisc: add TCA_XSTATS stats for fq qdisc. #980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using fq, we rely on xstats useful metrics to check fq behavior and diangosis, it is what can be seen from iproute2 tools, `tc -s qdisc show` as well. It exposes metrics as: https://github.com/iproute2/iproute2/blob/main/include/uapi/linux/pkt_sched.h#L847 Signed-off-by: Kangjie Xu <[email protected]>
middaywords
force-pushed
the
0605-nelink-tc-fq-xstats
branch
from
c4bbdd7 to
8e1ae8a
Compare
aboch
reviewed
Aug 29, 2025
| LowRateThreshold uint32 | ||
| Horizon uint32 | ||
| HorizonDropPolicy uint8 | ||
|
|
aboch
reviewed
Aug 29, 2025
| case nl.TCA_XSTATS: | ||
| switch qdisc.Type() { | ||
| case "fq": | ||
| fq := qdisc.(*Fq) |
There was a problem hiding this comment.
Please move this casting to line 499
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using fq, we rely on xstats useful metrics to check fq behavior and diangosis, it is what can be seen from iproute2 tools,
tc -s qdisc showas well. It exposes metrics as:https://github.com/iproute2/iproute2/blob/main/include/uapi/linux/pkt_sched.h#L847