Add union type and subtypes check in schema model signature (with tests) #1512
+259
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-blanchard
force-pushed
the
feat/add-uniontype-check
branch
from
25c2171 to
53d0b20
Compare
dan-blanchard
force-pushed
the
feat/add-uniontype-check
branch
from
53d0b20 to
f5694c0
Compare
|
I've rebased this since it got a little stale |
|
Hi @dan-blanchard - could you add missing tests coverage on ninja/signature/details.py lines - 212-215, 355-368 |
|
Note: #1483 can be related |
dan-blanchard
force-pushed
the
feat/add-uniontype-check
branch
from
f5694c0 to
63d426b
Compare
dan-blanchard
commented
Oct 6, 2025
ninja/testing/client.py
Outdated
| if self.streaming: | ||
| self.content = b"".join(http_response.streaming_content) # type: ignore | ||
| else: | ||
| self.content = http_response.content # type: ignore[union-attr] |
There was a problem hiding this comment.
mypy was complaining about this ignore being unnecessary for me
|
I rebased this on |
dan-blanchard
force-pushed
the
feat/add-uniontype-check
branch
from
63d426b to
4127e1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a rebased version of #1242 that also:
if type(arg) is None:instead ofif arg is type(None):