feature: Add a new endpoint for metamodels of view types. #121
Conversation
Clients make a `GET` request on the path `/vsum/views/types/metamodel`, and need to provide the view type as header. Servers respond with a JSON serialization of an `EPackage`. Implemented in the server with the ViewTypeMetamodelEndpoint, and in the client.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
checkstyle
Missing a Javadoc comment.
'member def modifier' has incorrect indentation level 4, expected level should be 2.
'ctor def modifier' has incorrect indentation level 4, expected level should be 2.
Line is longer than 100 characters (found 114).
'ctor def modifier' has incorrect indentation level 4, expected level should be 2.
Missing a Javadoc comment.
Extra separation in import group before 'org.eclipse.emf.ecore.EPackage'
Extra separation in import group before 'com.fasterxml.jackson.core.JsonProcessingException'
Wrong lexicographical order for 'com.fasterxml.jackson.core.JsonProcessingException' import. Should be before 'org.eclipse.emf.ecore.resource.ResourceSet'.
'}' at column 5 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally).
| @@ -1,62 +1,65 @@ | |||
| package tools.vitruv.framework.remote.server.http.java; | |||
|
|
|||
| import static java.net.HttpURLConnection.*; | |||
There was a problem hiding this comment.
Using the '.' form of import should be avoided - java.net.HttpURLConnection..
| this.endpoints = endpoints; | ||
| } | ||
| RequestHandler(PathEndpointCollector endpoints) { | ||
| this.endpoints = endpoints; |
There was a problem hiding this comment.
'ctor def' child has incorrect indentation level 6, expected level should be 4.
|
|
@HansMartinA Should I close this PR? |
Clients make a
GETrequest on the path/vsum/views/types/metamodel, and need to provide the view type as header.Servers respond with a JSON serialization of an
EPackage.Implemented in the server with the ViewTypeMetamodelEndpoint, and in the client.