fix: Make Recipe.model_dump() output compatible with model_validate() #1328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @ved1beta , thanks for the contribution! We should add some unit tests to make sure the recipes you checked manually get added to our CI tests. I can do this tomorrow, or if you have them handy still please add them to tests/llmcompressor/recipe/test_recipe.py
dsikka
added
ready
dsikka
requested changes
Apr 12, 2025
There was a problem hiding this comment.
Thank you for your PR!
Would you mind addressing the Quality Checks? You can install the required packages using the dev install and then running make style under the root directory.
Also, could you add the tests that you used to verify the changes? Thank you!
|
hey @dsikka made the changes please have look : ) |
dsikka
previously requested changes
Apr 14, 2025
There was a problem hiding this comment.
Thank you!
Do you mind addressing the quality failures? https://github.com/vllm-project/llm-compressor/actions/runs/14425964874/job/40461747095?pr=1328
Signed-off-by: Rahul Tuli <[email protected]>
|
Pushed Style Fixes; + merged main! |
brian-dellabetta
approved these changes
Apr 23, 2025
kylesayrs
approved these changes
Apr 23, 2025
dsikka
approved these changes
Apr 23, 2025
This was referenced Apr 23, 2025
dsikka
pushed a commit
that referenced
this pull request
Apr 24, 2025
This PR reverts commit 998be99 which was merged prematurely. The required base tests were skipped during the original review process. When these tests eventually ran on the main branch, they revealed a failure: https://github.com/vllm-project/llm-compressor/actions/runs/14628792870/job/41046641641 The original PR #1328 has been reopened to address the identified issues before resubmitting.
kylesayrs
added a commit
that referenced
this pull request
Apr 29, 2025
…#1328) SUMMARY: Fixed issue #1319 where Recipe.model_dump() output couldn't be used with Recipe.model_validate(). Implemented an override of the model_dump() method to ensure it produces output in the format expected by validation, enabling proper round-trip serialization using standard Pydantic methods. TEST PLAN: Created test cases to verify fix works with both simple and complex recipes Confirmed Recipe.model_validate(recipe.model_dump()) succeeds with various recipe formats Validated that recipes with multiple stages having the same group name serialize/deserialize correctly Ensured existing YAML serialization pathways continue to work as expected --------- Signed-off-by: Rahul Tuli <[email protected]> Co-authored-by: Dipika Sikka <[email protected]> Co-authored-by: Kyle Sayers <[email protected]> Co-authored-by: Rahul Tuli <[email protected]>
kylesayrs
pushed a commit
that referenced
this pull request
Apr 29, 2025
This PR reverts commit 998be99 which was merged prematurely. The required base tests were skipped during the original review process. When these tests eventually ran on the main branch, they revealed a failure: https://github.com/vllm-project/llm-compressor/actions/runs/14628792870/job/41046641641 The original PR #1328 has been reopened to address the identified issues before resubmitting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Fixed issue #1319 where Recipe.model_dump() output couldn't be used with Recipe.model_validate(). Implemented an override of the model_dump() method to ensure it produces output in the format expected by validation, enabling proper round-trip serialization using standard Pydantic methods.
TEST PLAN:
Created test cases to verify fix works with both simple and complex recipes
Confirmed Recipe.model_validate(recipe.model_dump()) succeeds with various recipe formats
Validated that recipes with multiple stages having the same group name serialize/deserialize correctly
Ensured existing YAML serialization pathways continue to work as expected