Skip to content

Fix wonky dependency range on datasets #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+4 −2
Closed

Fix wonky dependency range on datasets #1774

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,10 @@ def localversion_func(version: ScmVersion) -> str:
if BUILD_TYPE == "release"
else "transformers>=4.53.0"
),
# `datasets==4.0.0` is latest release, so
# pin directly. NOTE: add range after new release
(
"datasets>=4.0.0,<=4.0.0"
"datasets==4.0.0"
if BUILD_TYPE == "release"
else "datasets>=4.0.0"
),
Expand All @@ -163,7 +165,7 @@ def localversion_func(version: ScmVersion) -> str:
else "pynvml>=11.5.3"
),
(
"pillow>=10.4.0,<=10.4.0"
"pillow>=10.4.0,<11.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "<=10.4.0" was used initially to allow the upper bound testing to have a version to install from otherwise it doesn't know which one is the highest for "<11.0.0". We can make calls to the PyPi server to get that info but it'll add extra round-trip and I'd like to avoid that if possible. Also if there is newer version of 10.x.0 coming out, using "<11.0.0" will pick it up automatically which seems against the use of upper bound here since we want to be specific about the upper bound?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe we can just pin pillow here, i.e. "pillow==10.4.0"?

if BUILD_TYPE == "release"
else "pillow>=10.4.0"
),
Expand Down