Recovered skipped w8a8 compression related tests #1785
Merged
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shanjiaz <[email protected]>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
|
These will fail until the next transformers release? |
Yeah they won't work till our changes are applied |
Signed-off-by: shanjiaz <[email protected]>
…oject/llm-compressor into hz-recover-skipped-tests
Signed-off-by: shanjiaz <[email protected]>
…oject/llm-compressor into hz-recover-skipped-tests
Signed-off-by: shanjiaz <[email protected]>
Signed-off-by: shanjiaz <[email protected]>
Signed-off-by: shanjiaz <[email protected]>
kylesayrs
approved these changes
Sep 15, 2025
yeah the same code doesn't work if I don't move the models to cpu first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Recovered skipped w8a8 compression/decompression tests now that transformer side of code is merged. Added memory collection between test instances.
TEST PLAN:
tested locally on transformers 4.56.0.dev0 they passed.