Skip to content

Conversation

brian-dellabetta
Copy link
Collaborator

SUMMARY:
Cmarkgfm 2025.10.20 was released today, but the wheel build for linux is failing -- https://github.com/theacodes/cmarkgfm/actions/runs/18653185184

Pinning our version until this is resolved, as it breaks all ci/cd checks. Resolution likely in the next couple days.

TEST PLAN:
ci/cd passes on this branch

Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@brian-dellabetta brian-dellabetta added the ready When a PR is ready for review label Oct 20, 2025
Copy link
Contributor

Summary of Changes

Hello @brian-dellabetta, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to restore stability to the project's continuous integration and deployment pipelines by temporarily restricting the version of the cmarkgfm dependency. A recent release of cmarkgfm introduced a build failure on Linux, and pinning the dependency to an older, stable version prevents these failures, ensuring that development can proceed without interruption until the upstream issue is resolved.

Highlights

  • Dependency Pinning: The cmarkgfm dependency has been temporarily pinned to a version less than 2025.10.20.
  • CI/CD Stability: This change addresses a critical build issue introduced by the cmarkgfm 2025.10.20 release, which was causing all CI/CD checks to fail on Linux.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly pins the cmarkgfm dependency to a version before 2025.10.20 to resolve a build failure in CI/CD. The change is straightforward and effective. I've added one suggestion to rephrase the comment as a TODO to make this temporary fix more visible and easier to track for future removal.

Copy link
Collaborator

@fynnsu fynnsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the gemini suggestion. Otherwise looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready When a PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants