[DOC] update doc: LoRA with ACLGraph #2430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: paulyu12 <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for LoRA to reflect its compatibility with ACLGraph mode. The changes are well-contained and effective. The link text has been improved for clarity and accessibility, and the outdated tip about disabling graph mode has been correctly replaced with a new instruction pointing users to the ACLGraph guide for better performance. The update is clear and directly addresses the goal stated in the pull request description. The changes look good to me.
wangxiyuan
reviewed
Aug 19, 2025
Signed-off-by: paulyu12 <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
github-actions
bot
added
the
documentation
Signed-off-by: paulyu12 <[email protected]>
Signed-off-by: paulyu12 <[email protected]>
Signed-off-by: paulyu12 <[email protected]>
Signed-off-by: paulyu12 <[email protected]>
Signed-off-by: paulyu12 <[email protected]>
wangxiyuan
approved these changes
Aug 21, 2025
wangxiaoteng888
pushed a commit
to LCAIZJ/vllm-ascend
that referenced
this pull request
Sep 25, 2025
### What this PR does / why we need it? Update DOC. Guide users to run LoRA with ACLGraph. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No. - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@de7b67a --------- Signed-off-by: paulyu12 <[email protected]>
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Sep 26, 2025
### What this PR does / why we need it? Update DOC. Guide users to run LoRA with ACLGraph. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No. - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@de7b67a --------- Signed-off-by: paulyu12 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Update DOC. Guide users to run LoRA with ACLGraph.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No.